Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Wasmi executor #1206

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Optimize Wasmi executor #1206

merged 4 commits into from
Sep 29, 2024

Conversation

Robbepop
Copy link
Member

This brings Wasmi main executor performance roughly on par with v0.36.2.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (9f46524) to head (3387775).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/executor/instrs.rs 75.00% 2 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/load.rs 66.66% 2 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/store.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   80.80%   81.34%   +0.54%     
==========================================
  Files         299      302       +3     
  Lines       24886    24953      +67     
==========================================
+ Hits        20110    20299     +189     
+ Misses       4776     4654     -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit fd8dbd1 into main Sep 29, 2024
17 of 19 checks passed
@Robbepop Robbepop deleted the rf-try-opt-executor branch September 29, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant