Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve C-API prefix_symbol attribute macro #1317

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Conversation

Robbepop
Copy link
Member

Follow-up for #1315.

cc @xdoardo

  • Improves error handling and error reporting.
  • Makes macro code more readable.
  • Adds new checks to guard against misuse.
  • Remove misuses for non-Wasm spec API functions.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (4abde9c) to head (477d4b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
- Coverage   81.58%   81.57%   -0.01%     
==========================================
  Files         306      306              
  Lines       25271    25271              
==========================================
- Hits        20617    20616       -1     
- Misses       4654     4655       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit e25e3a8 into main Nov 27, 2024
19 checks passed
@Robbepop Robbepop deleted the rf-improve-c-api-macro branch November 27, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant