clippy: fix no_mangle and export_name usage
#1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The no_mangle and export_name attributes cannot be used at the same time. (Link: rust-lang/rust#47446) Since Clippy now warns about this we were notified about our misuse and this PR fixes it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1337 +/- ##
=======================================
Coverage 81.70% 81.70%
=======================================
Files 307 307
Lines 25336 25336
=======================================
Hits 20700 20700
Misses 4636 4636 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
no_mangleandexport_nameattributes cannot be used at the same time.(Link: rust-lang/rust#47446)
Since Clippy now warns about this we were notified about our misuse and this PR fixes it.
This will fix Wasmi's CI pipeline.
cc @xdoardo