-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuse i32.{and,or, xor}
+ [i32.eqz
] + br_if
Wasm instructions
#796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for i64 counterparts since in Wasm only i32 types are used as conditional "bool" types.
We added these instruction to provide optimizations for encode_eqz.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #796 +/- ##
==========================================
- Coverage 81.29% 81.07% -0.23%
==========================================
Files 273 273
Lines 25085 25204 +119
==========================================
+ Hits 20394 20435 +41
- Misses 4691 4769 +78 ☔ View full report in Codecov by Sentry. |
BENCHMARKS
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #791.
Added a new
fuse
benchmark that shows the performance improvements gained in this PR. The improvements in this artificial.wat
file are 25% compared to the currentmaster
branch which already implements branch+cmp fusion. Onmaster
each iteration executes 5wasmi
instructions whereas this PR gets it down to just 4 explaining the 25% performance improvement. Generally the gains are low for non-artificial tests such astiny_keccak
orcoremark.wasm
because they do not profit a lot from this op-code fusion in their hot loops it seems.TODO
i32.{and,or,xor}[_imm16]
+i32.eqz
fusion.i32.{and,or,xor}[_imm16]
+br_if
fusion.i32.{and,or,xor}[_imm16]
+i32.eqz
+br_if
fusion.