Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minor branch optimization in executor #806

Merged
merged 3 commits into from
Nov 25, 2023
Merged

Conversation

Robbepop
Copy link
Member

No description provided.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Nov 25, 2023

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
br_table
1.53ms 1.54ms ⚪ 0.02% 1.27ms 1.31ms 🔴 3.35% 🟢 -15%
execute/
call/host/1
36.99µs 37.08µs ⚪ 0.08% 39.52µs 39.61µs ⚪ 0.21% 🟢 7%
execute/
call/rec
166.10µs 165.27µs ⚪ -0.61% 357.11µs 351.92µs 🟢 -1.58% 🔴 113%
execute/
count_until
7.48ms 7.49ms ⚪ 0.14% 7.63ms 7.62ms ⚪ -0.12% 🟢 2%
execute/
factorial/iter
344.75µs 223.76µs 🟢 -35.23% 307.28µs 312.31µs 🔴 1.61% 🟢 40%
execute/
factorial/rec
753.73µs 689.82µs 🟢 -8.54% 1.28ms 1.28ms ⚪ 0.09% 🟡 86%
execute/
fibonacci/iter
1.36ms 1.36ms ⚪ 0.10% 1.27ms 1.27ms ⚪ 0.00% 🟢 -7%
execute/
fibonacci/rec
6.67ms 6.15ms 🟢 -7.94% 12.76ms 15.04ms 🔴 17.90% 🔴 145%
execute/
fibonacci/tail
1.57ms 1.46ms 🟢 -7.84% 3.64ms 3.69ms 🔴 1.29% 🔴 154%
execute/
fuse
8.19ms 7.90ms 🟢 -3.33% 12.57ms 12.58ms ⚪ 0.06% 🟡 59%
execute/
global/bump
1.32ms 1.32ms ⚪ 0.52% 1.60ms 1.60ms ⚪ -0.03% 🟢 21%
execute/
global/get_const
680.49µs 647.61µs 🟢 -4.57% 743.65µs 743.96µs ⚪ 0.01% 🟢 15%
execute/
is_even/rec
1.07ms 1.07ms ⚪ -0.44% 2.22ms 2.22ms ⚪ -0.22% 🔴 108%
execute/
memory/fill_bytes
1.14ms 1.14ms ⚪ 0.17% 1.23ms 1.23ms ⚪ -0.18% 🟢 7%
execute/
memory/sum_bytes
1.07ms 1.07ms ⚪ 0.47% 1.23ms 1.23ms ⚪ -0.04% 🟢 15%
execute/
memory/vec_add
2.95ms 2.95ms ⚪ 0.09% 3.56ms 3.56ms ⚪ -0.03% 🟢 21%
execute/
recursive_scan
185.66µs 185.51µs ⚪ -0.44% 377.11µs 371.66µs 🟢 -1.47% 🟡 100%
execute/
recursive_trap
15.36µs 15.23µs ⚪ -1.11% 35.92µs 34.53µs 🟢 -3.81% 🔴 127%
execute/
regex_redux
595.17µs 591.98µs ⚪ -0.43% 1.04ms 1.03ms ⚪ -0.85% 🟡 75%
execute/
rev_complement
445.45µs 442.25µs ⚪ -0.95% 632.93µs 633.06µs ⚪ 0.00% 🟢 43%
execute/
tiny_keccak
351.75µs 350.38µs ⚪ -0.48% 388.82µs 382.39µs 🟢 -1.50% 🟢 9%
execute/
trunc_f2i
623.19µs 619.01µs ⚪ -0.63% 949.12µs 948.99µs ⚪ 0.00% 🟡 53%
instantiate/
wasm_kernel
56.80µs 57.84µs ⚪ 0.48% 55.95µs 57.51µs 🔴 2.66% 🟢 -1%
overhead/
call/typed/0
1.23ms 1.25ms ⚪ 1.63% 850.86µs 863.21µs 🔴 1.36% 🟢 -31%
overhead/
call/typed/16
1.60ms 1.61ms ⚪ 0.51% 2.01ms 1.99ms ⚪ -0.91% 🟢 24%
overhead/
call/untyped/0
1.66ms 1.65ms ⚪ 0.03% 1.29ms 1.30ms ⚪ 0.71% 🟢 -21%
overhead/
call/untyped/16
2.47ms 2.39ms 🟢 -3.65% 3.83ms 3.83ms ⚪ 0.11% 🟡 61%
translate/
bz2
1.33ms 1.33ms ⚪ -0.58% 2.44ms 2.61ms 🔴 7.08% 🟡 97%
translate/
erc1155
278.63µs 277.78µs ⚪ 0.10% 472.16µs 491.06µs 🔴 3.74% 🟡 77%
translate/
erc20
135.68µs 135.72µs ⚪ 0.10% 227.01µs 236.40µs 🔴 4.45% 🟡 74%
translate/
erc721
191.08µs 192.54µs ⚪ 0.62% 327.10µs 340.82µs 🔴 4.15% 🟡 77%
translate/
pulldown_cmark
3.74ms 3.73ms ⚪ -0.26% 6.50ms 6.73ms 🔴 3.52% 🟡 81%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.36% 0.00ns 0.00ns 🔴 4.38% 🟢 0%
translate/
wasm_kernel
4.97ms 4.98ms ⚪ 0.17% 8.67ms 9.03ms 🔴 4.18% 🟡 81%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (834c3fb) 80.92% compared to head (276ca42) 80.93%.

❗ Current head 276ca42 differs from pull request most recent head bab9588. Consider uploading reports for the commit bab9588 to get more accurate results

Files Patch % Lines
crates/wasmi/src/engine/regmach/executor/instrs.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   80.92%   80.93%           
=======================================
  Files         274      274           
  Lines       25364    25366    +2     
=======================================
+ Hits        20527    20529    +2     
  Misses       4837     4837           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 80e1d21 into master Nov 25, 2023
13 checks passed
@Robbepop Robbepop deleted the rf-minor-opt branch November 25, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants