-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward osmosis unit model and Trevi's system flowsheet #114
Conversation
@Zhuoran29 can you check the failing tests? Just updated the repo to use WaterTAP v 1.0 so could be related to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't reviewed all the content yet, but left a few comments to fix before then.
src/watertap_contrib/reflo/analysis/example_flowsheets/test/test_fo_trevi_flowsheet.py
Outdated
Show resolved
Hide resolved
src/watertap_contrib/reflo/property_models/fo_draw_solution_properties.py
Outdated
Show resolved
Hide resolved
src/watertap_contrib/reflo/property_models/fo_draw_solution_properties.py
Outdated
Show resolved
Hide resolved
src/watertap_contrib/reflo/property_models/tests/test_FO_draw_solution_properties.py
Outdated
Show resolved
Hide resolved
src/watertap_contrib/reflo/unit_models/zero_order/forward_osmosis_zo.py
Outdated
Show resolved
Hide resolved
@kurbansitterley , Sorry for the late response. Yes, I've been looking into it and it seemed to need some more efforts to solve the convergence issue (seems related to an |
If it is related to the |
src/watertap_contrib/reflo/property_models/fo_draw_solution_properties.py
Show resolved
Hide resolved
src/watertap_contrib/reflo/property_models/fo_draw_solution_properties.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I am very impressed with this huge PR and think it is in great shape. There are a few code things to address and comments I left.
@kurbansitterley , thanks for the constructive suggestions. I've modified some of them and responded to those that I didn't change. Please feel free to follow with further comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Zhuoran29
This PR integrates the forward osmosis (FO) model developed from the Trevi System's pilot project and includes the following features: