GAC Test Harness #1311
Merged
GAC Test Harness #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 371 371
Lines 37922 37922
=======================================
Hits 35796 35796
Misses 2126 2126 ☔ View full report in Codecov by Sentry. |
|
I think the best thing to do is try to get this merged as the GAC unit test harness PR, and then have subsequent PR's for the costing test as we decide what we're doing with them. |
hunterbarber
requested review from
TimBartholomew,
MarcusHolly,
savannahsakhai and
kurbansitterley
MarcusHolly
approved these changes
Feb 27, 2024
savannahsakhai
approved these changes
Feb 27, 2024
bknueven
reviewed
Feb 29, 2024
| def configure(self): | ||
| m = build_hand() | ||
|
|
||
| self.unit_model_block = m.fs.unit |
There was a problem hiding this comment.
This is now optional, but it doesn't hurt.
Co-authored-by: bknueven <[email protected]>
bknueven
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
GAC in #1302
Summary/Motivation:
Consolidating GAC testing using new
UnitTestHarnessLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: