Add method to ED1d for calculating membrane resistance as a function of ion concentration #1522
+213
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbibl
changed the title
watertap/flowsheets/electrodialysis/electrodialysis_1stack_conc_recirc_ui.py
Outdated
Show resolved
Hide resolved
| self.membrane_set, | ||
| initialize=2e-4, | ||
| bounds=(1e-6, 1), | ||
| units=pyunits.ohm * pyunits.meter**2, | ||
| doc="Surface resistance of membrane", | ||
| doc="Constant areal resistance of membrane at high electrolyte concentration", |
There was a problem hiding this comment.
'High electrolyte' confused me. I assumed it meant in Concentrate channel. This really means resistance at infinite concentration, right?
There was a problem hiding this comment.
yes. I hesitated about using the infinite word as it's not practically meaningful. but I'll make an update.
| * sum( | ||
| self.diluate.properties[t, x].conc_mol_phase_comp["Liq", j] | ||
| * self.config.property_package.charge_comp[j] | ||
| for j in self.cation_set |
There was a problem hiding this comment.
The whole system is electrically neutral but does the diluate stay electrically neutral at every 'x'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: