Merge pull request #83 from lzdyes/main

fix: Google One Tap callback response error
wavezync · Aug 1, 2024 · 97b9f12 · 97b9f12
2 parents 17c5dcc + 926ebdc
commit 97b9f12
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/components/GoogleSignInButton.vue b/src/components/GoogleSignInButton.vue
@@ -244,7 +244,7 @@ watchEffect(() => {
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     client_id: clientId!,
     callback: (credentialResponse: CredentialResponse) => {
-      if (!credentialResponse.clientId || !credentialResponse.credential) {
+      if (!credentialResponse.credential) {
         emits("error");
         return;
       }

diff --git a/src/composables/useOneTap.ts b/src/composables/useOneTap.ts
@@ -219,7 +219,7 @@ export default function useOneTap(
       // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       client_id: clientId!,
       callback: (credentialResponse: CredentialResponse) => {
-        if (!credentialResponse.clientId || !credentialResponse.credential) {
+        if (!credentialResponse.credential) {
           onError?.();
           return;
         }

diff --git a/src/interfaces/accounts.ts b/src/interfaces/accounts.ts
@@ -57,12 +57,12 @@ export interface CredentialResponse {
   select_by?: SelectBy;
 
   /**
-   * Client ID returned from google
+   * This field is only defined when user clicks a Sign in with Google button to sign in, and the button's state attribute is specified.
    *
    * @type {string}
    * @memberof CredentialResponse
    */
-  clientId?: string;
+  state?: string;
 }
 
 /**