Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Google One Tap callback response does not contain clientId" #82

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Revert "fix: Google One Tap callback response does not contain clientId" #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/composables/useOneTap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ export default function useOneTap(
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
client_id: clientId!,
callback: (credentialResponse: CredentialResponse) => {
if (!credentialResponse.credential) {
if (!credentialResponse.clientId || !credentialResponse.credential) {
onError?.();
return;
}
Expand Down
4 changes: 2 additions & 2 deletions src/interfaces/accounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ export interface CredentialResponse {
select_by?: SelectBy;

/**
* This field is only defined when user clicks a Sign in with Google button to sign in, and the button's state attribute is specified.
* Client ID returned from google
*
* @type {string}
* @memberof CredentialResponse
*/
state?: string;
clientId?: string;
}

/**
Expand Down