Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix humanizeDurationSeconds func #75

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix humanizeDurationSeconds func #75

merged 1 commit into from
Aug 7, 2024

Conversation

adidenko
Copy link
Collaborator

@adidenko adidenko commented Aug 7, 2024

Description

If duration is more than 1000s, the function will panic.

Closes: #74

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

If duration is more than 1000s, the function will panic.

Closes: #74
Copy link
Collaborator

@njegosrailic njegosrailic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@adidenko adidenko merged commit eaece28 into main Aug 7, 2024
7 checks passed
@adidenko adidenko deleted the fix-74 branch August 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rare panic in main.humanizeDurationSeconds
2 participants