Skip to content

Commit

Permalink
Fix git conflict artifacts (#192)
Browse files Browse the repository at this point in the history
  • Loading branch information
Oded-B authored Jun 19, 2024
1 parent 99db0c0 commit bb49889
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
1 change: 0 additions & 1 deletion internal/pkg/configuration/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ type Config struct {
CommentArgocdDiffonPR bool `yaml:"commentArgocdDiffonPR"`
AutoMergeNoDiffPRs bool `yaml:"autoMergeNoDiffPRs"`
UseSHALabelForArgoDicovery bool `yaml:"useSHALabelForArgoDicovery"`

}

func ParseConfigFromYaml(y string) (*Config, error) {
Expand Down
11 changes: 0 additions & 11 deletions internal/pkg/githubapi/promotion.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ func getComponentConfig(ghPrClientDetails GhPrClientDetails, componentPath strin
return componentConfig, nil
}


// This function generates a list of "components" that where changed in the PR and are relevant for promotion)
func generateListOfRelevantComponents(ghPrClientDetails GhPrClientDetails, config *cfg.Config) (relevantComponents map[relevantComponent]struct{}, err error) {
relevantComponents = make(map[relevantComponent]struct{})
Expand All @@ -124,16 +123,6 @@ func generateListOfRelevantComponents(ghPrClientDetails GhPrClientDetails, confi
prom.InstrumentGhCall(resp)
if err != nil {
ghPrClientDetails.PrLogger.Errorf("could not get file list from GH API: err=%s\nstatus code=%v", err, resp.Response.Status)
return promotions, err
}
prFiles = append(prFiles, perPagePrFiles...)
if resp.NextPage == 0 {
break
}
opts.Page = resp.NextPage
}


return nil, err
}
prFiles = append(prFiles, perPagePrFiles...)
Expand Down

0 comments on commit bb49889

Please sign in to comment.