Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace filepath with key in callback request #165

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stefanneculai
Copy link

I believe it is more useful to send the key instead of filepath to the callback_url. For example, I need the key to do additional processing on the server. Amazon also returns the key and probably for the same reason. I don't see any reason why not to return the data from Amazon (url and key) and return filepath instead.

Moreover, the current implementation has several issues in IE9:

  • it was not returning the filepath, but only the path to the file. E.g. if the filepath would have been /uploads/foo/bar.jpg it was returning only /uploads/foo
  • the filepath should start with a /. For filepaths such as /uploads/foo/bar.jpg it was returning only uploads/foo
  • the filepath returned in IE9 was not encoded as it was in modern browsers.

@OleMchls
Copy link

👍 I was also in the need for the same. Not sure if this should remove existing fields, because BC. But I'd also to get key as a additional field!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants