add region to clean task, fix default key_starts_with #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault prefix_to_clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its seems reasonable that the default of key_starts_with and prefix_to_clean would be the same, since now it will never work - if key_starts_with is timestamp, but the prefix to clean is a datestamp, no files will ever be found like this
Now, each file should get uploaded (defaultly) in a uploads/20141128 folder and when searching for files to clean it will search for objects that start with a datestamp and not a up-to-the-second time stamp.
Also, task was missing a region, so bucket in non default region caused errors.