Remove .css to silence deprecation warning in sass-rails ~>5.0.1 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
|
Is this compatible with older rails versions? |
|
I believe so, but I haven't tested. I can take a look over the weekend. Or—since this is the only stylesheet and is very minimal—we could use vanilla CSS and drop the dependency on rails-sass altogether 😃 |
|
@jbarrieault yeah, there's another PR to drop the dependency on sass. Are we even using any sass features?! |
|
The stylesheet does use nesting which is sass. Well worth it to use pure css to lose the dependency! |
|
Closing since the dependency on SASS should be dropped all together, IMO. #193 does this, but conflicts need to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning logged when using with Rails 4.2.5 with
sass-rails5.0.1: