Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows to use @return tags in configs #314

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: allows to use @return tags in configs #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/refactoring.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
key: php-${{ matrix.php-version }}-composer-${{ matrix.dependencies }}-${{ hashFiles('composer.lock') }}
restore-keys: php-${{ matrix.php-version }}-composer-${{ matrix.dependencies }}-

- name: 📥 Install "${{ matrix.dependencies }}" dependencies
- name: 📥 Install "${{ matrix.dependencies }}" dependencies with composer
uses: wayofdev/gh-actions/actions/composer/[email protected]
with:
dependencies: ${{ matrix.dependencies }}
Expand Down
3 changes: 3 additions & 0 deletions src/RuleSets/DefaultSet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,25 +46,28 @@
/*
* @Symfony overrides
*/
'concat_space' => [

Check warning on line 49 in src/RuleSets/DefaultSet.php

View workflow job for this annotation

GitHub Actions / mutation-testing (ubuntu-latest, 8.1, locked) 

Escaped Mutant for Mutator "ArrayItemRemoval":

--- Original
+++ New
@@ @@
             /*
              * @symfony overrides
              */
-            'concat_space' => ['spacing' => 'one'],
+            'concat_space' => [],
             'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => true],
             'php_unit_method_casing' => ['case' => 'snake_case'],
             'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
'spacing' => 'one',
],
'method_argument_space' => [

Check warning on line 52 in src/RuleSets/DefaultSet.php

View workflow job for this annotation

GitHub Actions / mutation-testing (ubuntu-latest, 8.1, locked) 

Escaped Mutant for Mutator "ArrayItemRemoval":

--- Original
+++ New
@@ @@
              * @symfony overrides
              */
             'concat_space' => ['spacing' => 'one'],
-            'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => true],
+            'method_argument_space' => ['attribute_placement' => 'same_line', 'after_heredoc' => true],
             'php_unit_method_casing' => ['case' => 'snake_case'],
             'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
             'phpdoc_align' => ['align' => 'left'],
'on_multiline' => 'ensure_fully_multiline',
'attribute_placement' => 'same_line',
'after_heredoc' => true, // @PHP73Migration

Check warning on line 55 in src/RuleSets/DefaultSet.php

View workflow job for this annotation

GitHub Actions / mutation-testing (ubuntu-latest, 8.1, locked) 

Escaped Mutant for Mutator "TrueValue":

--- Original
+++ New
@@ @@
              * @symfony overrides
              */
             'concat_space' => ['spacing' => 'one'],
-            'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => true],
+            'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => false],
             'php_unit_method_casing' => ['case' => 'snake_case'],
             'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
             'phpdoc_align' => ['align' => 'left'],
],
'php_unit_method_casing' => [

Check warning on line 57 in src/RuleSets/DefaultSet.php

View workflow job for this annotation

GitHub Actions / mutation-testing (ubuntu-latest, 8.1, locked) 

Escaped Mutant for Mutator "ArrayItemRemoval":

--- Original
+++ New
@@ @@
              */
             'concat_space' => ['spacing' => 'one'],
             'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => true],
-            'php_unit_method_casing' => ['case' => 'snake_case'],
+            'php_unit_method_casing' => [],
             'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
             'phpdoc_align' => ['align' => 'left'],
             'phpdoc_to_comment' => ['allow_before_return_statement' => true],
'case' => 'snake_case',
],
'yoda_style' => [

Check warning on line 60 in src/RuleSets/DefaultSet.php

View workflow job for this annotation

GitHub Actions / mutation-testing (ubuntu-latest, 8.1, locked) 

Escaped Mutant for Mutator "ArrayItemRemoval":

--- Original
+++ New
@@ @@
             'concat_space' => ['spacing' => 'one'],
             'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => true],
             'php_unit_method_casing' => ['case' => 'snake_case'],
-            'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
+            'yoda_style' => ['identical' => false, 'less_and_greater' => false],
             'phpdoc_align' => ['align' => 'left'],
             'phpdoc_to_comment' => ['allow_before_return_statement' => true],
             'ordered_class_elements' => ['sort_algorithm' => 'none', 'order' => ['use_trait', 'constant_public', 'constant_protected', 'constant_private', 'property_public_static', 'property_public', 'property_protected_static', 'property_protected', 'property_private_static', 'property_private', 'construct', 'method_public_static', 'method_protected_static', 'method_private_static', 'method_public_abstract_static', 'method_protected_abstract_static', 'method_public_abstract', 'method_protected_abstract', 'phpunit', 'method_public', 'method_protected', 'method_private']],
'equal' => false,

Check warning on line 61 in src/RuleSets/DefaultSet.php

View workflow job for this annotation

GitHub Actions / mutation-testing (ubuntu-latest, 8.1, locked) 

Escaped Mutant for Mutator "FalseValue":

--- Original
+++ New
@@ @@
             'concat_space' => ['spacing' => 'one'],
             'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => true],
             'php_unit_method_casing' => ['case' => 'snake_case'],
-            'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
+            'yoda_style' => ['equal' => true, 'identical' => false, 'less_and_greater' => false],
             'phpdoc_align' => ['align' => 'left'],
             'phpdoc_to_comment' => ['allow_before_return_statement' => true],
             'ordered_class_elements' => ['sort_algorithm' => 'none', 'order' => ['use_trait', 'constant_public', 'constant_protected', 'constant_private', 'property_public_static', 'property_public', 'property_protected_static', 'property_protected', 'property_private_static', 'property_private', 'construct', 'method_public_static', 'method_protected_static', 'method_private_static', 'method_public_abstract_static', 'method_protected_abstract_static', 'method_public_abstract', 'method_protected_abstract', 'phpunit', 'method_public', 'method_protected', 'method_private']],
'identical' => false,

Check warning on line 62 in src/RuleSets/DefaultSet.php

View workflow job for this annotation

GitHub Actions / mutation-testing (ubuntu-latest, 8.1, locked) 

Escaped Mutant for Mutator "FalseValue":

--- Original
+++ New
@@ @@
             'concat_space' => ['spacing' => 'one'],
             'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => true],
             'php_unit_method_casing' => ['case' => 'snake_case'],
-            'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
+            'yoda_style' => ['equal' => false, 'identical' => true, 'less_and_greater' => false],
             'phpdoc_align' => ['align' => 'left'],
             'phpdoc_to_comment' => ['allow_before_return_statement' => true],
             'ordered_class_elements' => ['sort_algorithm' => 'none', 'order' => ['use_trait', 'constant_public', 'constant_protected', 'constant_private', 'property_public_static', 'property_public', 'property_protected_static', 'property_protected', 'property_private_static', 'property_private', 'construct', 'method_public_static', 'method_protected_static', 'method_private_static', 'method_public_abstract_static', 'method_protected_abstract_static', 'method_public_abstract', 'method_protected_abstract', 'phpunit', 'method_public', 'method_protected', 'method_private']],
'less_and_greater' => false,

Check warning on line 63 in src/RuleSets/DefaultSet.php

View workflow job for this annotation

GitHub Actions / mutation-testing (ubuntu-latest, 8.1, locked) 

Escaped Mutant for Mutator "FalseValue":

--- Original
+++ New
@@ @@
             'concat_space' => ['spacing' => 'one'],
             'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => true],
             'php_unit_method_casing' => ['case' => 'snake_case'],
-            'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
+            'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => true],
             'phpdoc_align' => ['align' => 'left'],
             'phpdoc_to_comment' => ['allow_before_return_statement' => true],
             'ordered_class_elements' => ['sort_algorithm' => 'none', 'order' => ['use_trait', 'constant_public', 'constant_protected', 'constant_private', 'property_public_static', 'property_public', 'property_protected_static', 'property_protected', 'property_private_static', 'property_private', 'construct', 'method_public_static', 'method_protected_static', 'method_private_static', 'method_public_abstract_static', 'method_protected_abstract_static', 'method_public_abstract', 'method_protected_abstract', 'phpunit', 'method_public', 'method_protected', 'method_private']],
],
'phpdoc_align' => [

Check warning on line 65 in src/RuleSets/DefaultSet.php

View workflow job for this annotation

GitHub Actions / mutation-testing (ubuntu-latest, 8.1, locked) 

Escaped Mutant for Mutator "ArrayItemRemoval":

--- Original
+++ New
@@ @@
             'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline', 'attribute_placement' => 'same_line', 'after_heredoc' => true],
             'php_unit_method_casing' => ['case' => 'snake_case'],
             'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
-            'phpdoc_align' => ['align' => 'left'],
+            'phpdoc_align' => [],
             'phpdoc_to_comment' => ['allow_before_return_statement' => true],
             'ordered_class_elements' => ['sort_algorithm' => 'none', 'order' => ['use_trait', 'constant_public', 'constant_protected', 'constant_private', 'property_public_static', 'property_public', 'property_protected_static', 'property_protected', 'property_private_static', 'property_private', 'construct', 'method_public_static', 'method_protected_static', 'method_private_static', 'method_public_abstract_static', 'method_protected_abstract_static', 'method_public_abstract', 'method_protected_abstract', 'phpunit', 'method_public', 'method_protected', 'method_private']],
             'global_namespace_import' => ['import_classes' => true, 'import_functions' => true, 'import_constants' => true],
'align' => 'left',
],
'phpdoc_to_comment' => [
'allow_before_return_statement' => true,
],

'ordered_class_elements' => [
'sort_algorithm' => 'none',
Expand Down
Loading