Add Wazuh version and links #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
AlexRuiz7
force-pushed
the
18-add-wazuh-metadata
branch
from
b2961ed
to
ef48e4d
Compare
AlexRuiz7
changed the title
Desvelao
reviewed
Apr 20, 2023
| }, | ||
|
|
||
| getWazuhDocVersion: () => { | ||
| return this.state.wazuhVersion.slice(0, 3) || 'current'; |
There was a problem hiding this comment.
nitpick: I would recommend another approach to get the value. This approach returns an unexpected value when the major or minor number has more than 1 digit, for example, 4.10 or 10.0.
suggestion: split by . and join the first two elements.
return this.state.wazuhVersion.split('.').slice(0, 2).join('.') || 'current';This should avoid possible future problems while using the version format of major.minor.patch.
AlexRuiz7
force-pushed
the
18-add-wazuh-metadata
branch
from
98d8a5a
to
e285cb9
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
**Partially depends on #22 **
This pull request completes some of the changes applied in #22 to add the documentation links of Wazuh to the help menu. The OpenSearch's links are replaced.
The documentation links are generated to match the version of the app, meaning that a Wazuh Dashboard at version 4.4.1 will link to the documentation of that version (4.4).
The version of the app is also shown in the menu. The version of Wazuh is defined in the
package.jsonfile, the loaded during runtime and injected to the section of the main HTML file.This is how it looks with the changes from #22 also applied (which changes the texts).
The links generated are:
Issues Resolved
#18
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr