Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit & functional tests #39

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Update unit & functional tests #39

merged 3 commits into from
Apr 19, 2023

Conversation

AlexRuiz7
Copy link
Member

@AlexRuiz7 AlexRuiz7 commented Apr 19, 2023 •
edited
Loading

Description

This pull request groups changes to the unit & functional tests in the repo, so other pull request modifying code pass.

Issues Resolved

Closes #38

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AlexRuiz7 AlexRuiz7 self-assigned this Apr 19, 2023
@AlexRuiz7 AlexRuiz7 linked an issue Apr 19, 2023 that may be closed by this pull request
Modify unit tests #38
Closed
@AlexRuiz7 AlexRuiz7 changed the title 38 modify unit tests Update unit & functional tests Apr 19, 2023
@AlexRuiz7
Copy link
Member Author

AlexRuiz7 commented Apr 19, 2023 •
edited
Loading

Remove commits 3d9ba6d5aad2aaea93bcee58a100961f737f9d45 and 3c6d5ea23ec54166e99111c3041f351efd00a2e5 from the branch 2.4.1 when the tests pass.

@AlexRuiz7 AlexRuiz7 merged commit 3b6c4f7 into 2.4.1 Apr 19, 2023
AlexRuiz7 added a commit that referenced this pull request Apr 20, 2023
@AlexRuiz7
Squashed commit of the following:
1e05628 
commit f4255aa
Author: yenienserrano <[email protected]>
Date:   Tue Apr 18 11:51:06 2023 +0200

    fix cypress test

commit 3b6c4f7
Author: Álex Ruiz <[email protected]>
Date:   Thu Apr 20 00:48:05 2023 +0200

    Update unit & functional tests (#39)

    * Fix functional tests

    * Update Browserslist: caniuse-lite

    Was preventing tests to pass

    * Update test snapshot
AlexRuiz7 added a commit that referenced this pull request Apr 20, 2023
@AlexRuiz7
Squashed commit of the following:
0fcbbac 
commit f4255aa
Author: yenienserrano <[email protected]>
Date:   Tue Apr 18 11:51:06 2023 +0200

    fix cypress test

commit 3b6c4f7
Author: Álex Ruiz <[email protected]>
Date:   Thu Apr 20 00:48:05 2023 +0200

    Update unit & functional tests (#39)

    * Fix functional tests

    * Update Browserslist: caniuse-lite

    Was preventing tests to pass

    * Update test snapshot
@AlexRuiz7
Copy link
Member Author

Re-opened in #48

See #1 (comment) for details.

yenienserrano pushed a commit that referenced this pull request May 8, 2023
@AlexRuiz7 @yenienserrano
Squashed commit of the following:
c2fe082 
commit f4255aa
Author: yenienserrano <[email protected]>
Date:   Tue Apr 18 11:51:06 2023 +0200

    fix cypress test

commit 3b6c4f7
Author: Álex Ruiz <[email protected]>
Date:   Thu Apr 20 00:48:05 2023 +0200

    Update unit & functional tests (#39)

    * Fix functional tests

    * Update Browserslist: caniuse-lite

    Was preventing tests to pass

    * Update test snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexRuiz7 AlexRuiz7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify unit tests
1 participant
@AlexRuiz7