Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitOpen #8756

Merged
merged 1 commit into from
May 23, 2023
Merged

Add GitOpen #8756

merged 1 commit into from
May 23, 2023

Conversation

gerardroche
Copy link
Contributor

https://github.com/gerardroche/sublime-git-open

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is Git Open

https://github.com/gerardroche/sublime-git-open

There are no packages like it in Package Control.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: GitOpen

Packages added:
  - GitOpen

Processing package "GitOpen"
  - All checks passed

@braver
Copy link
Collaborator

braver commented May 22, 2023

Would it make sense to add “open this file on remote”? I use that all the time via GitSavvy. There is also https://packagecontrol.io/packages/GitLink, I’d think that maybe there is something to be gained by integrating your work into that package?

@gerardroche
Copy link
Contributor Author

gerardroche commented May 23, 2023

I wasn't aware of the GitSavvy command. Probably because it is prefixed with "github:" in the Command Palette instead of GitSavvy. Very useful to know though. I've suggested adding "GitSavvy" to all those commands for discoverability.

GitLink is similar to git-open. One difference is that GitLink doesn't have a dependency on an external program, but then it's looking for a maintainer. GitOpen doesn't intend to handle any of the implementation details but will simply remain a wrapper around the external tool. I wouldn't be interested in maintaining something like GitLink.

I've been using git-open on the terminal since forever and have had this plugin in my local sublimefiles since forever too.

My bash alias: alias o='git-open'.
My neovintageousrc: nnoremap <leader>o :GitOpen<CR>

I might try changing that last one to github: open this file on remote.

@braver
Copy link
Collaborator

braver commented May 23, 2023

Thanks, that makes a lot of sense, I didn't see that you we're simply wrapping git-open, that's smart.

@braver braver merged commit 079d66d into wbond:master May 23, 2023
@gerardroche gerardroche deleted the add-git-open branch May 23, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants