Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JunLang #8820

Closed
wants to merge 6 commits into from
Closed

Add JunLang #8820

wants to merge 6 commits into from

Conversation

lemonorangeapple
Copy link
Contributor

@lemonorangeapple lemonorangeapple commented Sep 17, 2023

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is JunLang.

There are no packages like it in Package Control.

@braver
Copy link
Collaborator

braver commented Oct 5, 2023

Any particular reason you want to ship this pre-packaged? Your syntax is missing the .junlang suffix on all the scopes. It's also so limited I am really curious as to what the language is actually like?

@lemonorangeapple
Copy link
Contributor Author

lemonorangeapple commented Oct 13, 2023

@braver It's a simple program language, like Pascal, but simple than Pascal. How can this Pull Request be successfully merged? Add the .junlang suffix?

@braver
Copy link
Collaborator

braver commented Oct 15, 2023

Add the .junlang suffix?

Certainly, that for sure. I would also prefer simply adding the repository to the syntax as most other languages. That makes it easier for users to contribute to. I don't understand why you want a simple package like this to be shipped prepackaged. That's more typical for proprietary code, packages that need a build/compilation step, or companies wanting to manage several packages on their own.

@lemonorangeapple
Copy link
Contributor Author

Maybe I added the suffix, I don’t know is it the suffix.

@lemonorangeapple
Copy link
Contributor Author

@braver Can it work successful now?

@braver
Copy link
Collaborator

braver commented Oct 21, 2023

Please answer this question first:

@braver
Collaborator
braver commented 2 weeks ago
Any particular reason you want to ship this pre-packaged?

@lemonorangeapple
Copy link
Contributor Author

No. So can this package be can installed in Package Control?

@braver
Copy link
Collaborator

braver commented Oct 23, 2023

Sure it can, but preferable follow this example for how to add a syntax package:
https://github.com/wbond/package_control_channel/pull/8801/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants