Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates p.josn, Added PLI10 syntax highlighter #9002

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

Kostasn2
Copy link
Contributor

Added pli10 syntax highlighting.

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is a syntax highlighter for PLI10 pseudo-language.
A greek "programming language", with its own compiler, that is being teached to EAP (Elliniko Anoixto Panepisthmio, Hellenic Open Uniersity) in Greece, to the students for them to learn fundamentals of programming, programming logic and basic algorithmic structures.

There are no packages like it in Package Control.

Added pli10 syntax highlighting.
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: PLI10
Results help

Packages added:
  - PLI10

Processing package "PLI10"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: PLI10.sublime-syntax

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: PLI10
Results help

Packages added:
  - PLI10

Processing package "PLI10"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: PLI10.sublime-syntax

@Kostasn2
Copy link
Contributor Author

Kostasn2 commented Nov 17, 2024

Its a week now without any inormation, should i make any changes? Do you have any update about my package?

@Kostasn2
Copy link
Contributor Author

Hello, its almost a month now, is my package ok? Is anything i should fix?
Any update i should make?

Thanks in advance!

@Kostasn2
Copy link
Contributor Author

Kostasn2 commented Nov 29, 2024

@FichteFoll , Sorry for the ping and the tag, i just saw you are one of the collaborators.
Its almost a month now (3 weeks), and i have no update about my package.

Sorry for the tag, i appreciate all the effort you put in.

Thanks in advance

@braver
Copy link
Collaborator

braver commented Nov 30, 2024

This is a community project. Sometimes we're pretty quick, sometimes other things in life have more priority. Pinging people doesn't help usually, we get to it when we get to it.

Two remarks:

  • you might want to use a look ahead here so that the brackets aren't captured when all you want to do is pop out of the context.
  • since your snippets are only active in the scope of your syntax, I would personally drop the_pli10 suffix from the triggers.

@braver braver added feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side labels Nov 30, 2024
@Kostasn2
Copy link
Contributor Author

Kostasn2 commented Dec 1, 2024

This is a community project. Sometimes we're pretty quick, sometimes other things in life have more priority. Pinging people doesn't help usually, we get to it when we get to it.

Two remarks:

  • you might want to use a look ahead here so that the brackets aren't captured when all you want to do is pop out of the context.
  • since your snippets are only active in the scope of your syntax, I would personally drop the_pli10 suffix from the triggers.

I fixed the _pli10 suffix, and i got a little confused about what you said for the brackets.
The meaning is that when there is a bracket that is "alone" i want to be marked as invalid. And if there are brackets inside brackets then if the user tries to enters ')' for example while theρε is already a bracket like this, i want to pop "like going to the next one outside" until there is nothing else, and then it will be placed a ')' but it will be invalid if there is nothing to be paired.
For example:

image

Inside the '{}' if i enter the '}' it will see that there is a already a closing curly bracket so the cursor will go to the next closing bracket.

And again sorry for the previous πινγ, i understand there are priorities in life of caurse, its all my fault, iam really sorry for rushing things out. I understad that you are doing an amazing job and yes you are right having us pinging you, make things even worse.
It wont happen again.

Thanks again!

Have a nivce month!

@braver
Copy link
Collaborator

braver commented Dec 1, 2024

Excellent, no problem. Let's get this package out there then :)

@braver braver merged commit 073ff1c into wbond:master Dec 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants