Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "FindInFiles-addon" #9016

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add "FindInFiles-addon" #9016

merged 1 commit into from
Dec 11, 2024

Conversation

kaste
Copy link
Contributor

@kaste kaste commented Dec 5, 2024

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries.
  • My package does add key bindings with specific contexts.
  • There are no new commands.
  • There are no preferences (yet?)

My package is FindInFiles-addon. https://github.com/kaste/FindInFiles-addon

There are no packages like it in Package Control.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: FindInFiles-addon
Results help

Packages added:
  - FindInFiles-addon

Processing package "FindInFiles-addon"
  - WARNING: The binding ['alt+c'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['alt+r'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['alt+w'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['enter'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['escape'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The binding ['f5'] is also defined in default bindings but is masked with a 'context'
    - File: Default.sublime-keymap
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

@braver
Copy link
Collaborator

braver commented Dec 11, 2024

Wow, nice work. As usual 😉 This looks really useful!

I have basically just one remark, being that F5 isn’t normally a “refresh” shortcut on MacOS. In Sublime F5 sorts lines. In most apps, browsers etc. CMD+R refreshes the page. Most users will understand why F5 was chosen, but it’s not as natural and discoverable as it would be on Win/Linux.

@braver braver merged commit 42154bd into wbond:master Dec 11, 2024
2 checks passed
@kaste
Copy link
Contributor Author

kaste commented Dec 11, 2024

I added primary+r. 😼

@braver
Copy link
Collaborator

braver commented Dec 12, 2024

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants