Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LCOV plugin to default channel. #9019

Merged
merged 4 commits into from
Dec 14, 2024
Merged

Conversation

thraex-aquator
Copy link
Contributor

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **

My package is showing covered/missed lines based on an lcov.info file.

There are no packages like it in Package Control.

@kaste
Copy link
Contributor

kaste commented Dec 11, 2024

LGTM from here. I think it requires Sublime Text >=4000 though as you target (rightfully) python 3.8. Note that you don't need to instantiate Listener(); Sublime does it for you automatically.

@thraex-aquator
Copy link
Contributor Author

thraex-aquator commented Dec 12, 2024

Thanks for the heads-up! Bumped the version to 4000, also removed the extra initialization and reduced the visibility of the observer while I was already there. Moved the 1.0.0 tag to the current head as it was never really released before.

repository/l.json Outdated Show resolved Hide resolved
@braver
Copy link
Collaborator

braver commented Dec 13, 2024

Ugh, our tools don't want to run on GitLab repos. It looks good enough to just run with it and see what happens though 👍🏻

@thraex-aquator
Copy link
Contributor Author

Do I need to do anything else regarding being on gitlab, or you will handle it? (The suggested change is there)

@braver
Copy link
Collaborator

braver commented Dec 14, 2024

Ok, let’s see if it works. Maybe we need to add some metadata here, but we just need to check in a couple of hours.

@braver braver merged commit 9101f99 into wbond:master Dec 14, 2024
1 of 2 checks passed
@kaste
Copy link
Contributor

kaste commented Dec 14, 2024

✋ packagecontrol.io doesn't pick it up

@braver
Copy link
Collaborator

braver commented Dec 15, 2024

@kaste thanks reporting that. It seems to be a more widespread issue than just this package. I have no idea what might cause it. Of 5516 packages, 6 are on GitLab, half of which are missing. 🤷🏻

Will look into it: #9020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants