Reduces overrun for nukes and naplam #296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed that after I did it >_< not sure how I screwed that up the minor change is clear enough though just +20 to stop overrun on napalm. not such a big issue 10mil+ but below that its a pain. |
|
You didn´t really screw up, it´s just not worth it. |
|
I'd suggest not changing the |
adds button to manually disable nukes and napalm. This is for mainly laggy connection that are seeing their nukes fire on boss rounds even when not fired manually.
| @@ -61,7 +62,7 @@ | |||
| var control = { | |||
| speedThreshold: 2000, | |||
| // Stop using offensive abilities shortly before rain/wormhole rounds. | |||
| rainingSafeRounds: 5, | |||
| rainingSafeRounds: 9, | |||
There was a problem hiding this comment.
This variable should not be changed.
There was a problem hiding this comment.
fair enough I'll adjust canUseOffensiveAbility() to +4 to scope it to just office skills.
moved +4 raining safe round offset to canUseOffensiveAbility(). this reduces the chance of napalm over running at pre 10M. Also has the same affect on nukes and cluster bombs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed alot of nukes and napalm running over into Gold Helm rounds so i've increased the safe rounds to 9 and the napalm to 29 to try to stop this.
reason 9 and 29 is we still want to use these on pre Gold Helm bosses