Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Reweave - an effort to create a modern build system for weave net #3996

Open
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

rajch
Copy link
Contributor

@rajch rajch commented Aug 2, 2023

This is an effort to create a modern build environment for weave net, and simultaneously upgrade dependencies and the go compiler version.

This should solve some known problems, including:

  • Incompatibility with some versions of CNI and containerd
  • Vulnerabilities in the current weave images (2.8.1)
  • Mismatch between the Docker Hub hosted weave:latest and weave:2.8.1 images
  • Problems with multi-architecture images

rajch and others added 17 commits March 25, 2023 17:09
* golang.org/x/net to v0.8.0
* golang.org/x/crypto to v0.0.0-20220314234659-1baeb1ce4c0b
* github.com/aws/aws-sdk-go to v1.34.0
* github.com/prometheus/client_golang to v1.14.0
* k8s.io/client-go to v0.23.0
It had breaking changes, detailed in the reweave CHANGELOG
This was all work done previously by @hswong3i in
weaveworks#3939

All credit to them
Add one more BUILDPLATFORM as needed for down build
+ x1 more (try again) and it's linux/${TARGETARCH}

I thought that ${TARGETPLATFORM} was a thing according to this blog:
https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/
but it doesn't seem to be there reliably, whereas ${TARGETARCH} is set.

Signed-off-by: Kingdon Barrett <[email protected]>
Reweave (build on aarch64/macos with Rancher + Buildx)
@kingdonb
Copy link
Contributor

kingdonb commented Aug 4, 2023

Thank you for doing all this @rajch ! You are a pillar of the Weave Net community, I'm pleased to take a look at this today.

@kingdonb kingdonb self-requested a review August 4, 2023 13:02
@kingdonb
Copy link
Contributor

This is a mega-pr! 🎉 Thanks for pushing all this work, I will find time to review it soon.

I've been busy working on Flux v2.1 release, so we can get the docs in order and release them without any internal inconsistency. Sorry for the delays in merging this.

@rajch
Copy link
Contributor Author

rajch commented Nov 12, 2023

Some more CVEs had turned up. Resolved by upgrading dependencies.

Also made some aesthetic changes to scripts and build files
* github.com/containerd/containerd upgraded to v1.7.11
* github.com/opencontainers/runc upgraded to v1.1.12
* golang.org/x/crypto upgraded to v0.17.0
* Alpine base image upgraded to v3.19.1
* Module name changed to `github.com/rajch/weave`
* Added environment variable `CHECKPOINT_DISABLE=1` to default manifests, to bypass weaveworks telemetry
…GitHub Pages

* Copied, rearranged and modified the contents of the old site directory for Jekyll static site generator, into the website directory
* Added some Jekyll-specific things for looks, including:
  * _config.yaml, Gemfile.* and 404.html files
  * _data, _layouts and assets directories and their content
* Added .github/workflows/github-pages-publish.yml workflow
- Details in reweave/CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants