Skip to content

Commit

Permalink
Update src/ui/webeiddialog.cpp
Browse files Browse the repository at this point in the history
Co-authored-by: Mart Sõmermaa <[email protected]>
  • Loading branch information
lauris71 and mrts authored May 27, 2024
1 parent e4a335d commit eadbc5a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/ui/webeiddialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -556,10 +556,10 @@ void WebEidDialog::connectOkToCachePinAndEmitSelectedCertificate(

// Use setText() instead of clear() to clear undo/redo history as well.
ui->pinInput->setText({});
// TODO: To be sure that no copy of PIN text remains in memory, a custom
// widget should be implemented, that:
// - Stores PIN in locked byte vector
// - DOes not leak content through accessibility interface
// TODO: Implement a custom widget to ensure no copy of the PIN text remains in memory.
// The widget should:
// - store the PIN in a locked byte vector,
// - prevent content leaks via the accessibility interface.

emit accepted(certAndPin);
});
Expand Down

0 comments on commit eadbc5a

Please sign in to comment.