feat(babel-preset): support Jest to use node preset (#52)

web-infra-dev · Oct 12, 2023 · fd18cc3 · fd18cc3
1 parent a1a60b8
commit fd18cc3
Show file tree

Hide file tree

Showing 7 changed files with 75 additions and 77 deletions.
diff --git a/.changeset/tender-cougars-smash.md b/.changeset/tender-cougars-smash.md
@@ -0,0 +1,5 @@
+---
+'@rsbuild/babel-preset': patch
+---
+
+feat(babel-preset): support Jest to use node preset
diff --git a/packages/babel-preset/src/base.ts b/packages/babel-preset/src/base.ts
@@ -13,14 +13,16 @@ export const generateBaseConfig = (
     presetEnv = {},
     presetTypeScript = {},
     pluginDecorators = false,
-    pluginTransformRuntime = {},
   } = options;
 
   if (presetEnv) {
+    const isTest = process.env.NODE_ENV === 'test';
+
     config.presets?.push([
       require.resolve('@babel/preset-env'),
       {
-        modules: false,
+        // Jest only supports commonjs
+        modules: isTest ? 'commonjs' : false,
         exclude: ['transform-typeof-symbol'],
         ...presetEnv,
       },
@@ -43,34 +45,21 @@ export const generateBaseConfig = (
     ]);
   }
 
-  if (pluginTransformRuntime) {
-    config.plugins?.push([
-      require.resolve('@babel/plugin-transform-runtime'),
-      {
-        version: require('@babel/runtime/package.json').version,
-        // this option has been deprecated
-        // but enabling it can help to reduce bundle size
-        useESModules: true,
-      },
-    ]);
-  }
-
   if (pluginDecorators) {
     // link: https://github.com/tc39/proposal-decorators
     config.plugins?.push([
       require.resolve('@babel/plugin-proposal-decorators'),
       {
-        version: pluginDecorators.version,
         // decoratorsBeforeExport property is not allowed when version is legacy
         ...(pluginDecorators.version === '2018-09'
           ? { decoratorsBeforeExport: true }
           : {}),
+        ...pluginDecorators,
       },
     ]);
   }
 
   config.plugins?.push(
-    join(__dirname, './pluginLockCorejsVersion'),
     // Stage 1
     // link: https://github.com/tc39/proposal-export-default-from
     require.resolve('@babel/plugin-proposal-export-default-from'),

diff --git a/packages/babel-preset/src/node.ts b/packages/babel-preset/src/node.ts
@@ -8,9 +8,6 @@ export const getBabelConfigForNode = (options: NodePresetOptions = {}) => {
       presetEnv: {
         targets: ['node >= 14'],
       },
-      pluginTransformRuntime: {
-        regenerator: true,
-      },
     },
     options,
   );

diff --git a/packages/babel-preset/src/types.ts b/packages/babel-preset/src/types.ts
@@ -38,14 +38,14 @@ export type BasePresetOptions = {
   presetEnv?: PresetEnvOptions | false;
   presetTypeScript?: Record<string, unknown> | false;
   pluginDecorators?: PluginDecoratorsOptions | false;
-  pluginTransformRuntime?: Record<string, unknown> | false;
 };
 
 export type WebPresetOptions = BasePresetOptions & {
   presetEnv: PresetEnvOptions & {
     targets: PresetEnvTargets;
     useBuiltIns: PresetEnvBuiltIns;
   };
+  pluginTransformRuntime?: Record<string, unknown> | false;
 };
 
 export type NodePresetOptions = BasePresetOptions & {

diff --git a/packages/babel-preset/src/web.ts b/packages/babel-preset/src/web.ts
@@ -1,3 +1,4 @@
+import { join } from 'path';
 import { getCoreJsVersion } from '@rsbuild/shared';
 import { deepmerge } from '@rsbuild/shared/deepmerge';
 import { generateBaseConfig } from './base';
@@ -6,9 +7,6 @@ import type { BabelConfig, WebPresetOptions } from './types';
 export const getBabelConfigForWeb = (options: WebPresetOptions) => {
   const mergedOptions = deepmerge(
     {
-      pluginTransformRuntime: {
-        useESModules: true,
-      },
       presetEnv: {
         bugfixes: true,
         corejs: options.presetEnv.useBuiltIns
@@ -25,6 +23,23 @@ export const getBabelConfigForWeb = (options: WebPresetOptions) => {
   );
 
   const config = generateBaseConfig(mergedOptions);
+  const { pluginTransformRuntime = {} } = mergedOptions;
+
+  // Skip plugin-transform-runtime when testing
+  if (pluginTransformRuntime) {
+    config.plugins?.push([
+      require.resolve('@babel/plugin-transform-runtime'),
+      {
+        version: require('@babel/runtime/package.json').version,
+        // this option has been deprecated
+        // but enabling it can help to reduce bundle size
+        useESModules: true,
+        ...pluginTransformRuntime,
+      },
+    ]);
+  }
+
+  config.plugins?.push(join(__dirname, './pluginLockCorejsVersion'));
 
   return config;
 };

diff --git a/packages/babel-preset/tests/__snapshots__/node.test.ts.snap b/packages/babel-preset/tests/__snapshots__/node.test.ts.snap
@@ -3,14 +3,6 @@
 exports[`should provide node preset as expected 1`] = `
 {
   "plugins": [
-    [
-      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
-      {
-        "useESModules": true,
-        "version": "7.23.1",
-      },
-    ],
-    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-export-default-from/lib/index.js",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-partial-application/lib/index.js",
     [
@@ -28,7 +20,7 @@ exports[`should provide node preset as expected 1`] = `
         "exclude": [
           "transform-typeof-symbol",
         ],
-        "modules": false,
+        "modules": "commonjs",
         "targets": [
           "node >= 14",
         ],

diff --git a/packages/babel-preset/tests/__snapshots__/web.test.ts.snap b/packages/babel-preset/tests/__snapshots__/web.test.ts.snap
@@ -3,20 +3,12 @@
 exports[`should allow to enable legacy decorator 1`] = `
 {
   "plugins": [
-    [
-      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
-      {
-        "useESModules": true,
-        "version": "7.23.1",
-      },
-    ],
     [
       "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-decorators/lib/index.js",
       {
         "version": "legacy",
       },
     ],
-    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-export-default-from/lib/index.js",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-partial-application/lib/index.js",
     [
@@ -25,6 +17,14 @@ exports[`should allow to enable legacy decorator 1`] = `
         "proposal": "minimal",
       },
     ],
+    [
+      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
+      {
+        "useESModules": true,
+        "version": "7.23.1",
+      },
+    ],
+    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
   ],
   "presets": [
     [
@@ -35,7 +35,7 @@ exports[`should allow to enable legacy decorator 1`] = `
         "exclude": [
           "transform-typeof-symbol",
         ],
-        "modules": false,
+        "modules": "commonjs",
         "targets": [
           "Chrome >= 53",
         ],
@@ -59,21 +59,13 @@ exports[`should allow to enable legacy decorator 1`] = `
 exports[`should allow to enable specific version decorator 1`] = `
 {
   "plugins": [
-    [
-      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
-      {
-        "useESModules": true,
-        "version": "7.23.1",
-      },
-    ],
     [
       "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-decorators/lib/index.js",
       {
         "decoratorsBeforeExport": true,
         "version": "2018-09",
       },
     ],
-    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-export-default-from/lib/index.js",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-partial-application/lib/index.js",
     [
@@ -82,6 +74,14 @@ exports[`should allow to enable specific version decorator 1`] = `
         "proposal": "minimal",
       },
     ],
+    [
+      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
+      {
+        "useESModules": true,
+        "version": "7.23.1",
+      },
+    ],
+    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
   ],
   "presets": [
     [
@@ -92,7 +92,7 @@ exports[`should allow to enable specific version decorator 1`] = `
         "exclude": [
           "transform-typeof-symbol",
         ],
-        "modules": false,
+        "modules": "commonjs",
         "targets": [
           "Chrome >= 53",
         ],
@@ -116,14 +116,6 @@ exports[`should allow to enable specific version decorator 1`] = `
 exports[`should provide web preset as expected 1`] = `
 {
   "plugins": [
-    [
-      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
-      {
-        "useESModules": true,
-        "version": "7.23.1",
-      },
-    ],
-    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-export-default-from/lib/index.js",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-partial-application/lib/index.js",
     [
@@ -132,6 +124,14 @@ exports[`should provide web preset as expected 1`] = `
         "proposal": "minimal",
       },
     ],
+    [
+      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
+      {
+        "useESModules": true,
+        "version": "7.23.1",
+      },
+    ],
+    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
   ],
   "presets": [
     [
@@ -142,7 +142,7 @@ exports[`should provide web preset as expected 1`] = `
         "exclude": [
           "transform-typeof-symbol",
         ],
-        "modules": false,
+        "modules": "commonjs",
         "targets": [
           "Chrome >= 53",
         ],
@@ -166,14 +166,6 @@ exports[`should provide web preset as expected 1`] = `
 exports[`should support inject core-js polyfills by entry 1`] = `
 {
   "plugins": [
-    [
-      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
-      {
-        "useESModules": true,
-        "version": "7.23.1",
-      },
-    ],
-    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-export-default-from/lib/index.js",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-partial-application/lib/index.js",
     [
@@ -182,6 +174,14 @@ exports[`should support inject core-js polyfills by entry 1`] = `
         "proposal": "minimal",
       },
     ],
+    [
+      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
+      {
+        "useESModules": true,
+        "version": "7.23.1",
+      },
+    ],
+    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
   ],
   "presets": [
     [
@@ -195,7 +195,7 @@ exports[`should support inject core-js polyfills by entry 1`] = `
         "exclude": [
           "transform-typeof-symbol",
         ],
-        "modules": false,
+        "modules": "commonjs",
         "targets": [
           "Chrome >= 53",
         ],
@@ -219,14 +219,6 @@ exports[`should support inject core-js polyfills by entry 1`] = `
 exports[`should support inject core-js polyfills by usage 1`] = `
 {
   "plugins": [
-    [
-      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
-      {
-        "useESModules": true,
-        "version": "7.23.1",
-      },
-    ],
-    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-export-default-from/lib/index.js",
     "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-proposal-partial-application/lib/index.js",
     [
@@ -235,6 +227,14 @@ exports[`should support inject core-js polyfills by usage 1`] = `
         "proposal": "minimal",
       },
     ],
+    [
+      "<ROOT>/node_modules/<PNPM_INNER>/@babel/plugin-transform-runtime/lib/index.js",
+      {
+        "useESModules": true,
+        "version": "7.23.1",
+      },
+    ],
+    "<ROOT>/packages/babel-preset/src/pluginLockCorejsVersion",
   ],
   "presets": [
     [
@@ -248,7 +248,7 @@ exports[`should support inject core-js polyfills by usage 1`] = `
         "exclude": [
           "transform-typeof-symbol",
         ],
-        "modules": false,
+        "modules": "commonjs",
         "targets": [
           "Chrome >= 53",
         ],