-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support experimental loader emitDiagnostic
#7879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: feature
release: feature related release(mr only)
label
Sep 12, 2024
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
team
The issue/pr is created by the member of Rspack.
label
Sep 12, 2024
h-a-n-a
force-pushed
the
support-format-diagnostic
branch
2 times, most recently
from
September 12, 2024 12:52
941ddbd
to
2b937fe
Compare
h-a-n-a
force-pushed
the
support-format-diagnostic
branch
2 times, most recently
from
September 19, 2024 07:58
a4fd487
to
eecf87b
Compare
h-a-n-a
force-pushed
the
support-format-diagnostic
branch
from
September 19, 2024 10:53
25d572c
to
6c24a15
Compare
hardfist
reviewed
Sep 19, 2024
hardfist
reviewed
Sep 19, 2024
...spack-test-tools/tests/diagnosticsCases/module-build-failed/loader-emit-diagnostic/stats.err
Show resolved
Hide resolved
hardfist
reviewed
Sep 19, 2024
LGTM, waiting for @colinaaa's feedback on this |
hardfist
approved these changes
Sep 19, 2024
JSerFeng
pushed a commit
that referenced
this pull request
Sep 29, 2024
* feat: init * test: add * test: add * chore: cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: feature
release: feature related release(mr only)
team
The issue/pr is created by the member of Rspack.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #5913
Supported experimental loader API
emitDiagnostic
.This works almost the same as
emitError
oremitWarning
. But, it's for emitting rich-formatted diagnostics.Example
For loader:
it outputs:
Note: This is an experimental API and is rspack-specific.
Checklist