Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rspack): improve dependency location #7930

Closed
wants to merge 1 commit into from
Closed

refactor(rspack): improve dependency location #7930

wants to merge 1 commit into from

Conversation

shulaoda
Copy link
Collaborator

Summary

          LGTM. You could also replace name `RealDependencyRange` with `DependencyRange` and remove `ErrorSpan`. Both of them looks good to me.

Originally posted by @h-a-n-a in #7892 (comment)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda marked this pull request as draft September 19, 2024 15:36
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1539a18
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f18d1931fe8000080d8432

@shulaoda shulaoda closed this Nov 1, 2024
@shulaoda shulaoda deleted the refactor/dependency-location branch November 1, 2024 14:23
@shulaoda shulaoda mentioned this pull request Nov 1, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shulaoda