Add counters and list styles #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
jamesnw
commented
Sep 10, 2024
jamesnw
commented
Sep 10, 2024
| # firefox: "35" | ||
| # firefox_android: "35" | ||
| - css.properties.list-style-type.symbols | ||
| - css.properties.list-style.symbols |
There was a problem hiding this comment.
These could be a separate feature, potentially, but the similar css.at-rules.counter-style.symbols was included with the counter-style feature.
captainbrosset
requested changes
Sep 11, 2024
Co-authored-by: Patrick Brosset <[email protected]>
ddbeck
requested changes
Sep 26, 2024
captainbrosset
approved these changes
Sep 30, 2024
Merged
ddbeck
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Great, let's merge this now. @captainbrosset if there's more work on the description, please @ me or open a PR—we'll straighten it out.
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to work with the existing
@counter-styleandcounter-setfeatures, but a lot of this is long-term support, and didn't require the same level of granularity.