-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eme] Keystatuses test #3490
[eme] Keystatuses test #3490
Conversation
Reviewers for this pull request are: @ddorwin. |
var expected = [{ key: key1String, value: 'usable'}, { key: key2String, value: 'usable'}].sort( lexicographicalkey ); | ||
assert_object_equals(result, | ||
expected, | ||
'keyStatuses fails'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the assert text here be made more explicit? Instead of 'keystatuses fails', could it say 'keystatuses should return usable' or something like that?
I will mark other examples of this below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are text strings for asserts in utils.js that would need to be updated for consistency as well.
Comments from us are complete. Assert text could be more specific in some instances and assert_object_equals appears to be in the process of being removed from testharness. |
LGTM |
No description provided.