Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve select-parsing test readability #48699

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −19
Draft

Improve select-parsing test readability #48699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions html/semantics/forms/the-select-element/customizable-select/select-parsing.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,60 +55,57 @@
// The document.body check here and in the other tests is to make sure that a
// previous test case didn't leave the HTML parser open on another element.
assert_equals(document.getElementById('s1').parentNode, document.body);
assert_equals(document.getElementById('s1').innerHTML, `
<div>div 1</div>
assert_equals(document.getElementById('s1').innerHTML.trim(),
`<div>div 1</div>
<button>button</button>
<div>div 2</div>
<datalist>
<option>option</option>
</datalist>
<div>div 3</div>
`);
<div>div 3</div>`);
}, '<div>s, <button>s, and <datalist>s should be allowed in <select>.');

test(() => {
assert_equals(document.getElementById('s2').parentNode, document.body);
assert_equals(document.getElementById('s2').innerHTML, `
<button>button
assert_equals(document.getElementById('s2').innerHTML.trim(),
`<button>button
</button>`);
}, '</select> should close <button>.');

test(() => {
assert_equals(document.getElementById('s3').parentNode, document.body);
assert_equals(document.getElementById('s3').innerHTML, `
<datalist>datalist
assert_equals(document.getElementById('s3').innerHTML.trim(),
`<datalist>datalist
</datalist>`);
}, '</select> should close <datalist>.');

test(() => {
assert_equals(document.getElementById('s4').parentNode, document.body);
assert_equals(document.getElementById('s4').innerHTML, `
<button>
assert_equals(document.getElementById('s4').innerHTML.trim(),
`<button>
</button>`);
}, '<select> in <button> in <select> should remove inner <select>.');

test(() => {
assert_equals(document.getElementById('s5').parentNode, document.body);
assert_equals(document.getElementById('s5').innerHTML, `
<button>
assert_equals(document.getElementById('s5').innerHTML.trim(),
`<button>
<div>
</div></button>`);
}, '<select> in <select><button><div> should remove inner <select>.');

test(() => {
assert_equals(document.getElementById('s6').parentNode, document.body);
assert_equals(document.getElementById('s6').innerHTML, `
<div>
assert_equals(document.getElementById('s6').innerHTML.trim(),
`<div>
<option><img>option</option>
</div>
`);
</div>`);
}, 'Divs and imgs should be allowed as direct children of select and within options without a datalist.');

test(() => {
assert_equals(document.getElementById('s7').parentNode, document.body);
assert_equals(document.getElementById('s7').innerHTML, `
<input>
`);
assert_equals(document.getElementById('s7').innerHTML.trim(),
`<input>`);
}, 'Input tags should parse inside select instead of closing the select.');

test(() => {
Expand Down