-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement testdriver features (RFC-214) #49122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/features-bidi
branch
from
November 12, 2024 14:45
3a1f47a
to
a10955b
Compare
sadym-chromium
force-pushed
the
sadym/features-bidi
branch
3 times, most recently
from
November 13, 2024 14:23
58d1051
to
4212ce0
Compare
sadym-chromium
changed the title
[PROTOTYPE] Add
[PROTOTYPE RFC-214] Add Nov 14, 2024
testdriver_features
testdriver_features
sadym-chromium
changed the title
[PROTOTYPE RFC-214] Add
[PROTOTYPE] RFC-214 Add Nov 14, 2024
testdriver_features
testdriver_features
sadym-chromium
force-pushed
the
sadym/features-bidi
branch
13 times, most recently
from
November 20, 2024 13:48
c97ce07
to
bdf6e5f
Compare
sadym-chromium
force-pushed
the
sadym/features-bidi
branch
2 times, most recently
from
December 6, 2024 13:15
f9b4b30
to
7eb8d6d
Compare
sadym-chromium
force-pushed
the
sadym/features-bidi
branch
from
December 6, 2024 13:34
7eb8d6d
to
fea994b
Compare
sadym-chromium
changed the title
[PROTOTYPE] RFC-214 Add
[BLOCKED] RFC-214 Add Dec 6, 2024
testdriver_features
testdriver_features
OrKoN
approved these changes
Dec 6, 2024
sadym-chromium
force-pushed
the
sadym/features-bidi
branch
from
December 6, 2024 14:17
225ded7
to
47b2147
Compare
sadym-chromium
force-pushed
the
sadym/features-bidi
branch
from
December 17, 2024 21:27
0ed5c36
to
c329775
Compare
OrKoN
approved these changes
Dec 18, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
past
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few nits, but this looks good to me, thanks!
# Conflicts: # lint.ignore # tools/manifest/item.py
This was referenced Dec 19, 2024
sadym-chromium
force-pushed
the
sadym/features-bidi
branch
from
December 19, 2024 09:43
c329775
to
5d34df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testdriver features and use in chrome. Implementation of RFC 214: Add testdriver features.
feature=bidi
infrastructure/webdriver/bidi/subscription.html
for chromeinfrastructure/testdriver/bidi/permissions/set_permission.https.html
for chromeinfrastructure/metadata/infrastructure/testdriver/bidi/bluetooth/simulate_adapter.https.html
for chrome