Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement testdriver features (RFC-214) #49122

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Implement testdriver features (RFC-214) #49122

merged 8 commits into from
Dec 19, 2024

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Nov 12, 2024

Add testdriver features and use in chrome. Implementation of RFC 214: Add testdriver features.

  • Add testdriver features
  • Add lint rules
  • Enable bidi in chrome based on feature=bidi
  • Enable infrastructure/webdriver/bidi/subscription.html for chrome
  • Enable infrastructure/testdriver/bidi/permissions/set_permission.https.html for chrome
  • Enable infrastructure/metadata/infrastructure/testdriver/bidi/bluetooth/simulate_adapter.https.html for chrome

@sadym-chromium sadym-chromium force-pushed the sadym/features-bidi branch 3 times, most recently from 58d1051 to 4212ce0 Compare November 13, 2024 14:23
@sadym-chromium sadym-chromium changed the title [PROTOTYPE] Add testdriver_features [PROTOTYPE RFC-214] Add testdriver_features Nov 14, 2024
@sadym-chromium sadym-chromium changed the title [PROTOTYPE RFC-214] Add testdriver_features [PROTOTYPE] RFC-214 Add testdriver_features Nov 14, 2024
@sadym-chromium sadym-chromium force-pushed the sadym/features-bidi branch 13 times, most recently from c97ce07 to bdf6e5f Compare November 20, 2024 13:48
@sadym-chromium sadym-chromium force-pushed the sadym/features-bidi branch 2 times, most recently from f9b4b30 to 7eb8d6d Compare December 6, 2024 13:15
@sadym-chromium sadym-chromium changed the title [PROTOTYPE] RFC-214 Add testdriver_features [BLOCKED] RFC-214 Add testdriver_features Dec 6, 2024
@past

This comment was marked as duplicate.

@past past closed this Dec 18, 2024
auto-merge was automatically disabled December 18, 2024 18:45

Pull request was closed

@past past reopened this Dec 18, 2024
Copy link
Member

@past past left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few nits, but this looks good to me, thanks!

docs/writing-tests/testdriver.md Outdated Show resolved Hide resolved
tools/lint/lint.py Outdated Show resolved Hide resolved
tools/lint/lint.py Outdated Show resolved Hide resolved
tools/lint/tests/test_file_lints.py Outdated Show resolved Hide resolved
tools/lint/tests/test_file_lints.py Outdated Show resolved Hide resolved
tools/lint/tests/test_file_lints.py Outdated Show resolved Hide resolved
tools/lint/tests/test_file_lints.py Outdated Show resolved Hide resolved
tools/lint/tests/test_file_lints.py Outdated Show resolved Hide resolved
tools/manifest/sourcefile.py Show resolved Hide resolved
tools/manifest/sourcefile.py Show resolved Hide resolved
@past past merged commit f3acbb2 into master Dec 19, 2024
42 checks passed
@past past deleted the sadym/features-bidi branch December 19, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs infra lint manifest testdriver.js wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants