DOMException: Add test for Error.isError #49133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
requested changes
Nov 13, 2024
webidl/ecmascript-binding/es-exceptions/DOMException-is-error.any.js
Outdated
Show resolved
Hide resolved
domenic
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
LGTM. When whatwg/webidl#1421 is ready to merge, we can merge this.
5 tasks
ptomato
reviewed
Nov 14, 2024
…any.js Co-authored-by: Philip Chimento <[email protected]>
|
This should be good to merge, yeah? Would like to see these synced up to chromium so I don't have to write my own tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes tc39/test262#4322