Implement localized CSS quotes #49835
Open
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
wpt-pr-bot
approved these changes
Dec 24, 2024
servo-wpt-sync
force-pushed
the
servo_export_34770
branch
3 times, most recently
from
088c88d to
278fe6b
Compare
servo-wpt-sync
changed the title
servo-wpt-sync
force-pushed
the
servo_export_34770
branch
2 times, most recently
from
a2272d5 to
6268be8
Compare
Signed-off-by: Xiaocheng Hu <[email protected]>
Signed-off-by: Xiaocheng Hu <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_34770
branch
from
6268be8 to
4c030b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially implements CSS quotes (#34446):
quotesvalue, retrieves the quote data from the property valueautovalue:-x-langinternal property to track the computedlangattribute value-x-langvalue to determine current localeIt also removes the stale and incorrect UA sheet
quotes.cssthat is not used anywhere.Quote depth calculation is out of the scope of this PR and will be left for future.
Other caveats:
-x-langdoesn't track the browser/OS-default localeReviewed in servo/servo#34770