Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename popover=hint WPTs to remove .tentative #50103

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 15, 2025

The spec landed:

whatwg/html#9778

I also found one more that was just a general popover test that
likely should have been renamed a while ago.

Bug: 40256776
Change-Id: I57f0fb9f25b2e1d8b2b9509bb3c97786c6ac59ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168803
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406978}

The spec landed:

  whatwg/html#9778

I also found one more that was just a general popover test that
likely should have been renamed a while ago.

Bug: 40256776
Change-Id: I57f0fb9f25b2e1d8b2b9509bb3c97786c6ac59ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168803
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Di Zhang <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406978}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@mfreed7 mfreed7 mentioned this pull request Jan 16, 2025
4 tasks
Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/O4Is8lJtSheQZgoZgJfhEA/KwJ1N2XkSh-oAUCXOvPvCg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/O4Is8lJtSheQZgoZgJfhEA"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/O4Is8lJtSheQZgoZgJfhEA/KwJ1N2XkSh-oAUCXOvPvCg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/O4Is8lJtSheQZgoZgJfhEA"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-01-16T17:44:05.304Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/O4Is8lJtSheQZgoZgJfhEA/U1eBfu71SyqnK1VXoMCJ9w",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/O4Is8lJtSheQZgoZgJfhEA"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/O4Is8lJtSheQZgoZgJfhEA/U1eBfu71SyqnK1VXoMCJ9w",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/O4Is8lJtSheQZgoZgJfhEA"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-01-16T17:44:08.613Z

@dev-ansung dev-ansung closed this Jan 16, 2025
@dev-ansung dev-ansung reopened this Jan 16, 2025
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f3fb3b7 into master Jan 16, 2025
14 of 17 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-6168803 branch January 16, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants