This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
fix: offer to use collection instead of tenant #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/offer-to-use-collection-instead-of-tenant
branch
from
89a1e23
to
9bd9685
Compare
View stack outputs
|
|
I don't understand what "buckets" means in this context. |
alanshaw
reviewed
Sep 15, 2023
| tenant: string | ||
| // identifier of the collection for the tenant `did:web:web3.storage` | ||
| // spade relies on collections to identify different replication constraints. | ||
| collection: string |
There was a problem hiding this comment.
I'd suggest naming things we store under names that makes senses to us, and then mapping them at the points where we interface with spade. This would be "storefront" for us right?
There was a problem hiding this comment.
This is the bucket that Spade reads from us. In other words, this is the interface...
There was a problem hiding this comment.
Might be worth to read https://github.com/web3-storage/dealer/blob/main/docs/architecture.md#spade-integration + the issue where we iterated on format in calls with Spade team #7 (comment)
@alanshaw
alanshaw
approved these changes
Sep 18, 2023
vasco-santos
deleted the
fix/offer-to-use-collection-instead-of-tenant
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were building assuming that we could use one bucket and set the
tenantID as the way to integrate with Spade. This approach would also be tricky in future scenarios where we wanted to have the ability to have different configurations per SLA things (in case it materializes).Talking with @jcace (SEE) about
storefrontproperty and whether we could rely on a friendly name (e.g.did:web:web3.storage) instead of an internal ID, we concluded that Spade would require a different bucket per tenant. However, each tenant MAY have different collections with different Replication Constraints.We were asked to have different buckets per tenant, and swap
tenantintocollection. For now, we will also actually just have one tenant, so we can figure out later how could we have dynamic tenant world without needing to manually provision a bucket.