Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filecoin deals about text #1407

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

dchoi27
Copy link
Contributor

@dchoi27 dchoi27 commented Jun 6, 2022

Changed some of the wording about the client making the Filecoin deals. Per #1042 (comment), let's delete this section (lines 121 to 123 here) for now. I could use help doing this since it doesn't seem as simple as deleting the JSON blob.

@yusefnapora
Copy link
Contributor

@dchoi27 I was able to remove that section, but I had to also remove the images at left to avoid a broken layout.

Here's what it looks like after my commit:
2022-06-06 - web3-storage-about-changes

Vs the current page, showing the file upload interface, etc:

2022-06-06 - web3-storage-about-current

There might be a way to keep the images without coming up with some replacement text, but someone more familiar with the code could probably figure it out faster than me 😄

@olizilla
Copy link
Contributor

olizilla commented Jun 8, 2022

@dchoi27 please close out #1381 if it's not the change you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants