fix: do not render account blocked modal unless account restricted #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnathonroach
approved these changes
Nov 8, 2022
jsdevel
deleted the
1998-blocked-modal-overlay-flashes-briefly-sometimes-when-browsing-web3storage-website
branch
johnathonroach
pushed a commit
that referenced
this pull request
Nov 14, 2022
🤖 I have created a release *beep* *boop* --- ## [2.32.0](website-v2.31.0...website-v2.32.0) (2022-11-11) ### Features * add twitter logo to contact page [#2068](#2068) ([#2078](#2078)) ([179a844](179a844)) * **docs:** remove decentralized storage concept doc ([#2102](#2102)) ([f65c82e](f65c82e)) ### Bug Fixes * align links when stacking mobile ([#2088](#2088)) ([3bedf2d](3bedf2d)) * do not render account blocked modal unless account restricted ([#2089](#2089)) ([1025a22](1025a22)) * incorrect class use ([#2094](#2094)) ([6919cb0](6919cb0)) * remove web apps footer link ([#2087](#2087)) ([a8c16a8](a8c16a8)) * rm staging url in PSA docs ([#2037](#2037)) ([2dcc4dc](2dcc4dc)) * typo in w3name product page ([#2098](#2098)) ([9b50cc9](9b50cc9)) * update product pages to have appropriate descriptions and titles ([#2085](#2085)) ([ae6ed12](ae6ed12)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1998
There's a reported issue where the Account Blocked modal displays briefly when navigating the site. I haven't yet been able to reproduce this, but currently this modal always renders (and is just hidden with CSS). This PR is an optimization to prevent the modal from rendering at all. It will hopefully resolve the issue, but it will also reduce the size of the prerendered HTML.