-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade swarm-js to ^0.1.40 #3403
Conversation
Hey Team -- do we know that is blocking this PR from getting merged? |
@rraina There's no blocker - this will go in the next release. Fwiw the security vuln at issue here does not actually impact this project - |
@cgewecke -- Thanks for the prompt response! Completely understand that this is just a cosmetic change; it's just a little annoying since it causes errors on our CI process :) |
@rraina Yes, understood - it's annoying. Just mentioning it in case there's real concern about whether the dep is safe. |
Yup - thank you for clarifying, and your efforts on this project! Hope you are keeping safe! |
Thanks for merging it! |
Description
Silences npm audit warning reported in #3399. One of swarm-js's dependencies was flagged as high vuln. Resolved by swarm-js 36
NB: floating this dep now because that's been recommended in #3186 and @evertonfraga is a maintainer.
Fixes #3399
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases do cover all lines and branches of the added code.npm run build-all
and tested the resulting file/'s fromdist
folder in a browser.CHANGELOG.md
file in the root folder.