Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #388 - improved codebase by removing objectNested #389

Merged
merged 1 commit into from
May 18, 2021
Merged

fixes #388 - improved codebase by removing objectNested #389

merged 1 commit into from
May 18, 2021

Conversation

magsout
Copy link
Member

@magsout magsout commented May 14, 2021 •
edited
Loading

par of #388

removed objectNested by using optional-chaining andcoalescing-operator providing by the browser

@magsout
Issue #388 - removed objectNested
5df6951 
- removed lib
- added babel nullish-coalescing-operator and optional-chaining
@magsout magsout changed the title fixes #388 - improved codebase fixes #388 - improved codebase by removing objectNested May 14, 2021
@magsout magsout requested review from karlcow and ksy36 May 14, 2021 08:35
@magsout magsout marked this pull request as ready for review May 14, 2021 08:35
@ksy36 ksy36 merged commit 8613742 into master May 18, 2021
@ksy36 ksy36 deleted the issues/388/1 branch May 18, 2021 00:14
@ksy36
Copy link
Contributor

ksy36 commented May 18, 2021

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksy36 ksy36 ksy36 approved these changes

@karlcow karlcow Awaiting requested review from karlcow

Assignees
No one assigned
Labels
scope : frontend type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magsout @ksy36 @karlcow