Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Avoid overwriting existing capabilities object #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vbyjsue
Copy link

@vbyjsue vbyjsue commented Jan 17, 2018

fixes #15

@jsf-clabot
Copy link

jsf-clabot commented Jan 17, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we modify the integration tests to make sure that we can now also apply custom options?

@vbyjsue
Copy link
Author

vbyjsue commented Jan 18, 2018

Looking into the tests and find that they don't work? I'm confused over this part:

if (!Array.isArray(config.firefoxProfile.extensions)) {
 return this.buildExtension();
}

If you supply an extension, no profile is added since it is done in buildExtension?
Also when I launch programmatically caps is passed as array in firefox-profile-lauch-service.js but with cli it's passed as an object which makes it never enter the profile setting part:

if (Array.isArray(_this2.caps))

Maybe I'm missing something?

@Filipoliko
Copy link

Bump
Hi, can this be merged, or are there still some changes required? Just ran into this bug and it would be great to have this working as expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firefoxProfile object overwrites supplied capabilities
4 participants