Use PHPStan #75
Open
Use PHPStan #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PHPStan and and make the code comply with the most strict level.
I noticed a few
@psalm-internalannotations and I am unsure how to run the Psalm and I think it is not enforced and maintained anymore. There isTranslationInterfaceof generic typeTTranslatedValuebut non of its implementation is generic.In this pull request, I propose to use PHPStan. There may be few quirky behaviours (mostly replacement of empty function and places where
ShouldNotHappenis thrown) so please review them carefully.Do any of the properties of
TranslatableClassMetadataneeds to be nullable? When i was researching usage of$translationsCollectionPropertyI found out it does not need to be nullable at all. Am i missing something here?