Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dedicated AttributeDriver, deprecate annotations #9

Merged
merged 7 commits into from
Apr 4, 2024

Conversation

mpdude
Copy link
Member

@mpdude mpdude commented Apr 4, 2024

This PR prepares the removal of annotations support, which helps to prepare https://github.com/webfactory/BGObjectRoutingBundle for Symfony 7.

symfony/framework-bundle 7.x does not ship the annotation_reader anymore, and instead of wiring up an annotation reader ourselves, I'd prefer to go down the attributes path.

@mpdude mpdude merged commit aab21ab into master Apr 4, 2024
3 checks passed
@mpdude mpdude deleted the attribute-driver branch April 4, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant