-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Admin UI - Colors and Theming #4474
Draft
adrians5j
wants to merge
41
commits into
feat/new-admin-ui
Choose a base branch
from
feat/theming-token-improvements
base: feat/new-admin-ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat/theming-token-improvements
…into feat/theming-token-improvements # Conflicts: # apps/admin/package.json # package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For starters, this PR brings in the primitive tokens for colors (check theme out here).
With these tokens now in
theme.scss
, we now reference them in alias tokens. Previously, alias tokens directly had color codes assigned to them.All of this ultimately enables easier Admin theme customization, which is done via the new
AdminConfig.Theme
React component. Here are two examples.There are a couple of things to note though.
First, not that the
AdminConfig.Theme
component is actually NOT a React properties component.packages/app-wcp/src/WcpProvider.tsx
Second, while I was testing the above code examples, I noticed glitches. ✍🏻
Additional Changes
1. Minor Cleanups
1.1.
packages/app-admin-cognito/src/components/StyledComponents.ts
Saw links in the sign in screen still orange, because there was some custom styling done with the
--mdc-theme-...
CSS variables.1.2.
packages/app-admin-rmwc/src/modules/Navigation/Styled.ts
Removed custom styling since it was no longer needed. There will be probably more to remove but for now didn't go too far.
1.3.
packages/app-admin/src/styles/material-theme-assignments.scss
Accidentally saw this file and decided to remove CSS that I was sure we won't be needing any more (old components). More cleaning up in this file will be needed.
2. Updated
app-serverless-cms
ExportsThis package now exports not only the new
AdminConfig
, but also the tenancy-related components. Better to have everything in one place (easier for users).3. Removed Component Mount Tracking
Component mount tracking was removed in
packages/app-tenant-manager/src/index.tsx
. This basically resolved an issue where, in a MT setup, in a specific case you would not see the tenant selector in top-right corner of the screen. Thanks goes to Pavel for this one.How Has This Been Tested?
Manually.
Documentation
Add theming doc.