Welcome to Ruby

webmat · May 25, 2018 · 4f9bc4f · 4f9bc4f
1 parent cf048a3
commit 4f9bc4f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/logstash/outputs/elasticsearch/helpers.rb b/lib/logstash/outputs/elasticsearch/helpers.rb
@@ -1,5 +1,7 @@
 # Small functions that don't require a full instance of the plugin should go here.
 # This will promote lightning fast tests.
+#
+# Methods are defined right on the module to ensure no context can be shared with the plugin instance :-)
 module LogStash; module Outputs; class ElasticSearch;
   module Helpers
     INDEX_REQUIRING_TIMESTAMP = /%{\+.+\}/

diff --git a/spec/unit/outputs/elasticsearch_helpers.rb b/spec/unit/outputs/elasticsearch_helpers.rb
@@ -4,8 +4,8 @@
 
 describe LogStash::Outputs::ElasticSearch::Helpers do
   context "detecting if an index name can be determined for an event" do
-    let(:event_with_ts) { LogStash::Event.new() }
-    let(:event_with_no_ts) { LogStash::Event.new().tap { |e| e.remove('@timestamp') } }
+    let(:event_with_ts) { LogStash::Event.new }
+    let(:event_with_no_ts) { LogStash::Event.new.tap { |e| e.remove('@timestamp') } }
 
     context "when the index pattern doesn't include a timestamp" do
       ['my-index', 'logstash-%{normal_field_interpolation}'].each do |index|