-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Disable Extracting Specified CSS Module from Chunks #432
Open
lsycxyj
wants to merge
25
commits into
webpack-contrib:master
Choose a base branch
from
lsycxyj:feature/disable_async_20190719
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
39b36e9
feat: ability to disable extract async modules
lsycxyj 188cf5c
feat: ability to disable extract async modules, lint fix
lsycxyj 4a7a1f6
feat: ability to disable extract async modules, add doc
lsycxyj 399aa9a
feat: ability to disable extract async modules, ci fix
lsycxyj 26646ae
feat: ability to disable extract async modules, order fix
lsycxyj 08b8e52
feat: ability to disable extract async modules, wrong initial chunks fix
lsycxyj 775cc0c
feat: ability to disable extract async modules, add manual test
lsycxyj f9d7df1
feat: ability to disable extract async modules, update lock file
lsycxyj c38cc8c
feat: ability to disable extract async modules, add tests for js files
lsycxyj e2177fd
feat: ability to disable extract modules, wip
lsycxyj 4982afb
feat: ability to disable extract modules, remove duplicated dependencies
lsycxyj 81517cc
feat: ability to disable extract modules, update doc
lsycxyj 5b3fbef
feat: ability to disable extract modules, remove boolean type option
lsycxyj 1da949e
feat: ability to disable extract modules, less code difference
lsycxyj e59a0e1
feat: ability to disable extract modules, less code difference
lsycxyj 37ce619
Merge remote-tracking branch 'origin/feature/disable_async_20190719' …
lsycxyj 6001569
feat: ability to disable extract modules, less regressions
lsycxyj b986c54
feat: ability to disable extract modules, ci fix
lsycxyj fa58310
feat: ability to disable extract modules, ci fix
lsycxyj 5de6572
feat: ability to disable extract modules, replace private property
lsycxyj 5b2c6d3
feat: ability to disable extract modules, remove useless code
lsycxyj 2f29038
merge from master WIP
lsycxyj f0358d0
fix wrong modules after disable extraction
lsycxyj cbcfbc5
Merge remote-tracking branch 'upstream/master' into feature/disable_a…
lsycxyj 40af212
fix wrong modification and update package-lock.json
lsycxyj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.async-import { | ||
background: black; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.async { | ||
background: blue; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import './in-async'; | ||
import './in-async2.css'; | ||
import './in-async.css'; | ||
import './both-async.css'; | ||
|
||
import './both-page-async-disabled.css'; | ||
import './both-page-async.css'; | ||
|
||
// console.log('async.js'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import './both-page-async-disabled.css'; | ||
import './both-page-async.css'; | ||
import './is-async1.css'; | ||
|
||
// console.log('async2.js'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
@import 'shared.css'; | ||
|
||
.both-async { | ||
color: red; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.both-page-async-disabled { | ||
color: yellow; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.both-page-async { | ||
color: cyan; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
.async-import { | ||
background: black; | ||
} | ||
|
||
.in-async-2 { | ||
background: green; | ||
} | ||
|
||
.both-page-async { | ||
color: cyan; | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name it in positive way e.g. should extract