Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style panel tooltips should have a link to mdn #4383

Open
kof opened this issue Nov 7, 2024 · 9 comments · May be fixed by #4416
Open

Style panel tooltips should have a link to mdn #4383

kof opened this issue Nov 7, 2024 · 9 comments · May be fixed by #4416
Assignees
Labels
complexity:low Good for newcomers, up to a few days of work prio:1 The most important thing to work on type:feat Features and enhancements

Comments

@kof
Copy link
Member

kof commented Nov 7, 2024

Every style panel tooltip for a property or value should have a link icon that leads user to mdn. All these links can be built at runtime since mdn has structured urls.

@kof kof added type:feat Features and enhancements prio:1 The most important thing to work on complexity:low Good for newcomers, up to a few days of work labels Nov 7, 2024
@JayaKrishnaNamburu
Copy link
Contributor

Here is the two variations we can connect these links, any suggestions on which looks better ?

Screenshot 2024-11-11 at 8 51 37 AM Screenshot 2024-11-11 at 8 55 30 AM

@kof
Copy link
Member Author

kof commented Nov 11, 2024

Another option is top right corner on the same level as title, making sure title would be shortened with ellipsis if it is too long

@kof
Copy link
Member Author

kof commented Nov 11, 2024

And using external link icon

@JayaKrishnaNamburu
Copy link
Contributor

external_link
Screenshot 2024-11-12 at 7 27 46 PM

@kof
Copy link
Member Author

kof commented Nov 12, 2024

Wrong icon, there is an "external link" icon

@kof
Copy link
Member Author

kof commented Nov 12, 2024

also noticed - cursor should be pointer on external links

@kof
Copy link
Member Author

kof commented Nov 12, 2024

Just checked, we actually failed to use an anchor element for external link icons probably because we don't have a link icon component in the design system

@JayaKrishnaNamburu
Copy link
Contributor

Will take care of all the things, placement wise and integration wise. Looking fine ?

@kof
Copy link
Member Author

kof commented Nov 12, 2024

Yeah, I think placement looks fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:low Good for newcomers, up to a few days of work prio:1 The most important thing to work on type:feat Features and enhancements
Projects
None yet
2 participants