Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add links to mdn documentation inside tooltips for sections and properties #4416

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JayaKrishnaNamburu
Copy link
Contributor

@JayaKrishnaNamburu JayaKrishnaNamburu commented Nov 13, 2024

Description

fixes #4383
Tweaked the __generated__/properties.ts that is generated at build time to store mdn_url in it. And use these url's to show on the tooltips for the properties and sections.

Steps for reproduction

  • Open any property, and the tooltip opens
  • Inside the tooltip, you should be able to click on the external link icon.
  • The link should take you to a mdn link of the same.

external-links

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)

Before requesting a review

  • made a self-review

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)

@kof kof requested a review from TrySound November 13, 2024 10:24
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving from ux perspective, technical review up to @TrySound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style panel tooltips should have a link to mdn
2 participants