Moment #143
Closed
Moment #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windmemory
reviewed
Sep 8, 2021
Comment on lines
+516
to
+518
| abstract postTextMoment (content: string, visibleList?: string[]) : Promise<string> | ||
| abstract postLinkMoment (urlLinkPayload: UrlLinkPayload, content?: string) : Promise<string> | ||
| abstract postImageMoment (images: FileBox[], content?: string) : Promise<string> |
There was a problem hiding this comment.
Is that possible to merge these functions into one?
| abstract momentPayload (id: string) : Promise<MomentPayload> | ||
|
|
||
| abstract momentList (option?: MomentListOption) : Promise<string[]> | ||
| abstract revokeMoment (id: string) : Promise<boolean> |
There was a problem hiding this comment.
Is delete or remove better than revoke?
There was a problem hiding this comment.
Please see https://cloud.google.com/apis/design/standard_methods and let's follow the google APIs recommendation for standard methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #142